netdev - Re: [PATCH net-next 00/11] mlxsw: extend line card model by devices and info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c740b60-78eb-d0df-369c-d8411e24a054@gmail.com>
Date:   Mon, 30 May 2022 20:11:16 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Jakub Kicinski <kuba@...nel.org>, Ido Schimmel <idosch@...sch.org>,
        Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
        davem@...emloft.net, pabeni@...hat.com, jiri@...dia.com,
        petrm@...dia.com, andrew@...n.ch, mlxsw@...dia.com
Subject: Re: [PATCH net-next 00/11] mlxsw: extend line card model by devices
 and info

On 5/29/22 3:24 AM, Jiri Pirko wrote:
> Sat, May 28, 2022 at 05:58:56PM CEST, dsahern@...il.com wrote:
>> On 5/24/22 8:31 AM, Jiri Pirko wrote:
>>>
>>> $ devlink lc info pci/0000:01:00.0 lc 8
>>> pci/0000:01:00.0:
>>
>> ...
>>
>>>
>>> $ devlink lc flash pci/0000:01:00.0 lc 8 file mellanox/fw-AGB-rel-19_2010_1312-022-EVB.mfa2
>>
>>
>> A lot of your proposed syntax for devlink commands has 'lc' twice. If
>> 'lc' is the subcommand, then you are managing a linecard making 'lc'
>> before the '8' redundant. How about 'slot 8' or something along those lines?
> 
> Well, there is 1:1 match between cmd line options and output, as always.
> 
> Object name is one thing, the option name is different. It is quite
> common to name them both the same. I'm not sure I understand why it
> would be an issue.
> 

example? To me it says something is off in your model when you want to
use the same keyword twice in a command line.