netdev - Re: [PATCH iproute2-next] ip: Convert non-constant initializers to macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YpYiUJlmp0X5jH0S@shredder>
Date:   Tue, 31 May 2022 17:12:32 +0300
From:   Ido Schimmel <idosch@...dia.com>
To:     Petr Machata <petrm@...dia.com>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...il.com>,
        Tariq Toukan <tariqt@...dia.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next] ip: Convert non-constant initializers to
 macros

On Tue, May 31, 2022 at 01:35:48PM +0200, Petr Machata wrote:
> As per the C standard, "expressions in an initializer for an object that
> has static or thread storage duration shall be constant expressions".
> Aggregate objects are not constant expressions. Newer GCC doesn't mind, but
> older GCC and LLVM do.
> 
> Therefore convert to a macro. And since all these macros will look very
> similar, extract a generic helper, IPSTATS_STAT_DESC_XSTATS_LEAF, which
> takes the leaf name as an argument and initializes the rest as appropriate
> for an xstats descriptor.
> 
> Reported-by: Stephen Hemminger <stephen@...workplumber.org>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Patch is directed at iproute2-next, but code is already in main branch

Fixes: d9976d671c37 ("ipstats: Expose bond stats in ipstats")
Fixes: 36e10429dafc ("ipstats: Expose bridge stats in ipstats")
Reviewed-by: Ido Schimmel <idosch@...dia.com>

Fixes the build issue with clang on my laptop