netdev - Re: [PATCH net] net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e96d6ae-bc97-9915-5f72-901c04dee3c2@gmail.com>
Date:   Wed, 1 Jun 2022 15:03:37 +0900
From:   Toshiaki Makita <toshiaki.makita1@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Jamal Hadi Salim <jhs@...atatu.com>
Cc:     Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Paul Blakey <paulb@...dia.com>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net/sched: act_api: fix error code in
 tcf_ct_flow_table_fill_tuple_ipv6()

On 2022/05/31 21:10, Dan Carpenter wrote:
> The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return
> false on failure.  It should not return negatives because that means
> succes/true.
> 
> Fixes: fcb6aa86532c ("act_ct: Support GRE offload")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thank you!

Acked-by: Toshiaki Makita <toshiaki.makita1@...il.com>