netdev - [PATCH net-next v3 0/3] reorganize the code of the enum skb_drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220601065238.1357624-1-imagedong@tencent.com>
Date:   Wed,  1 Jun 2022 14:52:35 +0800
From:   menglong8.dong@...il.com
To:     kuba@...nel.org
Cc:     rostedt@...dmis.org, mingo@...hat.com, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com, nhorman@...driver.com,
        ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org,
        imagedong@...cent.com, dsahern@...nel.org, talalahmad@...gle.com,
        keescook@...omium.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: [PATCH net-next v3 0/3] reorganize the code of the enum skb_drop_reason

From: Menglong Dong <imagedong@...cent.com>

The code of skb_drop_reason is a little wild, let's reorganize them.
Three things and three patches:

1) Move the enum 'skb_drop_reason' and related function to the standalone
   header 'dropreason.h', as Jakub Kicinski suggested, as the skb drop
   reasons are getting more and more.

2) use auto-generation to generate the source file that convert enum
   skb_drop_reason to string.

3) make the comment of skb drop reasons kernel-doc style.

Changes since v2:
2/3: - add new line in the end of .gitignore
     - fix awk warning by make '\;' to ';', as ';' is not need to be
       escaped
     - export 'drop_reasons' in skbuff.c

Changes since v1:
1/3: move dropreason.h from include/linux/ to include/net/ (Jakub Kicinski)
2/3: generate source file instead of header file for drop reasons string
     array (Jakub Kicinski)
3/3: use inline comment (Jakub Kicinski)

Menglong Dong (3):
  net: skb: move enum skb_drop_reason to standalone header file
  net: skb: use auto-generation to convert skb drop reason to string
  net: dropreason: reformat the comment fo skb drop reasons

 include/linux/skbuff.h     | 179 +-------------------------
 include/net/dropreason.h   | 257 +++++++++++++++++++++++++++++++++++++
 include/trace/events/skb.h |  89 +------------
 net/core/.gitignore        |   1 +
 net/core/Makefile          |  23 +++-
 net/core/drop_monitor.c    |  13 --
 net/core/skbuff.c          |   3 +
 7 files changed, 285 insertions(+), 280 deletions(-)
 create mode 100644 include/net/dropreason.h
 create mode 100644 net/core/.gitignore

-- 
2.36.1