netdev - Re: [PATCH] net-sysfs: allow changing sysfs carrier when interface is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220602095756.764471e8@kernel.org>
Date:   Thu, 2 Jun 2022 09:57:56 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Joakim Tjernlund <Joakim.Tjernlund@...inera.com>
Cc:     "stephen@...workplumber.org" <stephen@...workplumber.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] net-sysfs: allow changing sysfs carrier when interface
 is down

On Thu, 2 Jun 2022 16:26:18 +0000 Joakim Tjernlund wrote:
> On Thu, 2022-06-02 at 08:56 -0700, Stephen Hemminger wrote:
> > > Sure, our HW has config/state changes that makes it impossible for net driver
> > > to touch and registers or TX pkgs(can result in System Error exception in worst case.

What is "our HW", what kernel driver does it use and why can't the
kernel driver take care of making sure the device is not accessed
when it'd crash the system?

> Maybe so but it seems to me that this limitation was put in place without much thought.

Don't make unnecessary disparaging statements about someone else's work.
Whoever that person was.