netdev - Re: [PATCH v2 0/3] Split "nfc: st21nfca: Refactor EVT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Jun 2022 23:10:37 +0400
From:   Denis Efremov <denis.e.efremov@...cle.com>
To:     Martin Faltesek <mfaltesek@...omium.org>, netdev@...r.kernel.org,
        kuba@...nel.org, krzk@...nel.org, christophe.ricard@...il.com,
        jordy@...ing.systems
Cc:     sameo@...ux.intel.com, wklin@...gle.com, groeck@...gle.com,
        mfaltesek@...gle.com, gregkh@...uxfoundation.org,
        theflamefire89@...il.com, Pavel Machek <pavel@....cz>
Subject: Re: [PATCH v2 0/3] Split "nfc: st21nfca: Refactor EVT_TRANSACTION"
 into 3

Hi,

On 4/1/22 22:09, Martin Faltesek wrote:
> Changes in v2:
>         -- Split the original patch into 3 patches, so that each one solves
>            a single issue. The original patch indicated 4 bugs, but two are
>            so closely related that I feel it makes sense to keep them
>            together.
> 
>         -- 1/3
>            nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
> 
>            This is mentioned in v1 as #1.  It just changes logical AND to
>            logical OR. The AND was rendering the check useless.
> 
>         -- 2/3
>            nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling
> 
>            This is from v1 #3.
> 
>         -- 3/3
>            nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION
> 
>            This is from v1 #2 and #4
>            Both are derived from the same bug, which is the incorrect calculation
>            that buffer allocation size is skb->len - 2, so both should be combined.
> 
>         After these 3 patches are applied, the end result is the same as v1
>         except:
> 
>         -- minor comment rewording.
>         -- removed some comments which felt superfluous explanations of
>            obvious code.
> 
> Martin Faltesek (3):
>   nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
>   nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling
>   nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION
> 
>  drivers/nfc/st21nfca/se.c | 51 +++++++++++++++++++++++----------------
>  1 file changed, 30 insertions(+), 21 deletions(-)
> 

Ping?

Denis