netdev - RE: [PATCH] net: eth: altera: set rx and tx ring size before init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Jun 2022 01:40:49 +0000
From:   "Tham, Mun Yew" <mun.yew.tham@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Joyce Ooi <joyce.ooi@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net: eth: altera: set rx and tx ring size before init_dma
 call

> On Tue, 31 May 2022 10:51:17 +0800 Tham, Mun Yew wrote:
> > It is more appropriate to set the rx and tx ring size before calling 
> > the init function for the dma.

> Improve the commit message please, this tells us nothing.
> It's hardly a well know software design best practice to set some random thing before calling another random thing.
> AFAICT neither dma implementation upstream cares about
> priv->[tr]x_ring_size, do they?

> If you're doing this to prepare for adding another DMA engine, please post this patch together with the support being added.
Noted, will post this patch together. Thanks.