netdev - Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c5a6bb34c67c9c15c393346e89bdb14ae6f3c44.camel@pschenker.ch>
Date:   Thu, 02 Jun 2022 10:44:13 +0200
From:   Philippe Schenker <dev@...henker.ch>
To:     sean.wang@...iatek.com
Cc:     deren.wu@...iatek.com, kvalo@...nel.org,
        linux-wireless@...r.kernel.org, nbd@....name, linux@...mhuis.info,
        davem@...emloft.net, kuba@...nel.org, lorenzo.bianconi83@...il.com,
        matthias.bgg@...il.com, pabeni@...hat.com, ryder.lee@...iatek.com,
        shayne.chen@...iatek.com, yn.chen@...iatek.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"

On Thu, 2022-06-02 at 06:23 +0800, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> > On Tue, 2022-04-12 at 19:06 +0800, Deren Wu wrote:
> > > On Tue, 2022-04-12 at 12:37 +0300, Kalle Valo wrote:
> > > > Philippe Schenker <dev@...henker.ch> writes:
> > > > 
> > > > > This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
> > > > > 
> > > > > This commit introduces a regression on some systems where the
> > > > > kernel is crashing in different locations after a reboot was
> > > > > issued.
> > > > > 
> > > > > This issue was bisected on a Thinkpad P14s Gen2 (AMD) with
> > > > > latest
> > > > > firmware.
> > > > > 
> > > > > Link:
> > > > > https://urldefense.com/v3/__https://lore.kernel.org/linux-wireless
> > > > > /5077a953487275837e81bdf1808ded00b9676f9f.camel@...henker.ch/_
> > > > > _;!!
> > > > > CTRNKA9wMg0ARbw!09tjyaQlMci3fVI3yiNiDJKUW_qwNA_CbVhoAraeIX96B9
> > > > > 9Q14
> > > > > J4iDycWA9cq36Y$
> > > > > 
> > > > > Signed-off-by: Philippe Schenker <dev@...henker.ch>
> > > > 
> > > > Can I take this to wireless tree? Felix, ack?
> > > > 
> > > > I'll also add:
> > > > 
> > > > Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default")
> > > > 
> > > 
> > > Hi Kalle,
> > > 
> > > We have a patch for a similar problem. Can you wait for the
> > > verification by Philippe?
> > > Commit 602cc0c9618a81 ("mt76: mt7921e: fix possible probe failure
> > > after
> > > reboot")
> > > Link:
> > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kerne
> > > l/git/torvalds/linux.git/commit/drivers/net/wireless/mediatek/mt76
> > > ?id=
> > > 602cc0c9618a819ab00ea3c9400742a0ca318380__;!!CTRNKA9wMg0ARbw!3N9I3
> > > iKwS
> > > 3XCNAb4LuhbFqt_el1yiOaJzSdUjaJsTaxRCHiWhXnEgbk3bOqYTy6T$
> > > 
> > > I can reproduce the problem in my v5.16-rc5 desktop. And the issue
> > > can
> > > be fixed when the patch applied.
> > > 
> > > 
> > > Hi Philippe,
> > > 
> > > Can you please help to check the patch in your platform?
> > 
> > Hi Kalle and Deren,
> > 
> > I just noticed on my system and mainline v5.18 reboots do now work
> > however Bluetooth is no longer accessible after a reboot.
> > 
> > Reverting commit bf3747ae2e25dda6a9e6c464a717c66118c588c8 on top of
> > v5.18 solves this problem for me.
> > 
> > @Deren are you aware of this bug?
> > @Kalle Is there a bugtracker somewhere I can submit this?
> 
> Hi Philippe,
> 
> Could you try the latest firmware to see if it can help with the issue
> you reported here ?
> 
> Please check out
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/mediatek
> and replace the following three files in /lib/firmware/mediatek on
> your target and reboot
> 1) BT_RAM_CODE_MT7961_1_2_hdr.bin
> 2) WIFI_MT7961_patch_mcu_1_2_hdr.bin
> 3) WIFI_RAM_CODE_MT7961_1.bin
> 
>         Sean

Hi Sean,

Thanks for your suggestion. I downloaded the firmwares from the link you
indicated and downloaded the three firmwares from main branch. I checked
and the sha256sums of the most recent firmwares match with the one
installed by my distribution. So I already had latest versions on my
tests.

Philippe

> 
> > 
> > Thanks,
> > Philippe
> > 
> > > 
> > > 
> > > Regards,
> > > Deren
> > > 
> > 
> > 
> >