netdev - Re: [PATCH bpf-next v8 08/11] libbpf: implement bpf_prog_query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKH8qBthw-7Nse+=xeys1t=Q+f8VwQWu-zuHMGC+_CJUSrX6zg@mail.gmail.com>
Date:   Fri, 3 Jun 2022 16:13:15 -0700
From:   Stanislav Fomichev <sdf@...gle.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>
Subject: Re: [PATCH bpf-next v8 08/11] libbpf: implement bpf_prog_query_opts

On Fri, Jun 3, 2022 at 2:35 PM Andrii Nakryiko
<andrii.nakryiko@...il.com> wrote:
>
> On Wed, Jun 1, 2022 at 12:02 PM Stanislav Fomichev <sdf@...gle.com> wrote:
> >
> > Implement bpf_prog_query_opts as a more expendable version of
> > bpf_prog_query. Expose new prog_attach_flags and attach_btf_func_id as
> > well:
> >
> > * prog_attach_flags is a per-program attach_type; relevant only for
> >   lsm cgroup program which might have different attach_flags
> >   per attach_btf_id
> > * attach_btf_func_id is a new field expose for prog_query which
> >   specifies real btf function id for lsm cgroup attachments
> >
> > Signed-off-by: Stanislav Fomichev <sdf@...gle.com>
> > ---
> >  tools/include/uapi/linux/bpf.h |  3 +++
> >  tools/lib/bpf/bpf.c            | 40 +++++++++++++++++++++++++++-------
> >  tools/lib/bpf/bpf.h            | 15 +++++++++++++
> >  tools/lib/bpf/libbpf.map       |  2 +-
> >  4 files changed, 51 insertions(+), 9 deletions(-)
> >
>
> Few consistency nits, but otherwise:
>
> Acked-by: Andrii Nakryiko <andrii@...nel.org>

Thank you for the review, agreed, will address everything in a respin.