netdev - Re: [PATCH net-next] net: atm: remove the ambassador driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220603152950.3057543-1-gprocida@google.com>
Date:   Fri,  3 Jun 2022 16:29:50 +0100
From:   Giuliano Procida <gprocida@...gle.com>
To:     tsbogend@...ha.franken.de
Cc:     3chas3@...il.com, arnd@...nel.org, dan.carpenter@...cle.com,
        davem@...emloft.net, jj@...osbits.net, kuba@...nel.org,
        linux-atm-general@...ts.sourceforge.net,
        linux-mips@...r.kernel.org, myxie@...ian.org,
        netdev@...r.kernel.org, p.zabel@...gutronix.de, pabeni@...hat.com,
        Giuliano Procida <gprocida@...gle.com>
Subject: Re: [PATCH net-next] net: atm: remove the ambassador driver

On Wed, 6 Apr 2022 at 13:11:25 +0200, Thomas Bogendoerfer wrote:

> On Tue, Apr 05, 2022 at 09:16:27PM -0700, Jakub Kicinski wrote:
> > The driver for ATM Ambassador devices spews build warnings on
> > microblaze. The virt_to_bus() calls discard the volatile keyword.
> > The right thing to do would be to migrate this driver to a modern
> > DMA API but it seems unlikely anyone is actually using it.
> > There had been no fixes or functional changes here since
> > the git era begun.
> >
> > In fact it sounds like the FW loading was broken from 2008
> > 'til 2012 - see commit fcdc90b025e6 ("atm: forever loop loading
> > ambassador firmware").
> >
> > Let's remove this driver, there isn't much changing in the APIs,
> > if users come forward we can apologize and revert.
> >

I contributed this driver (and the horizon one) over 20 years ago. I
doubt the hardware has been used in 20 years.

I just spoke today with David Miller about finally removing them and
found that you've already started.

Please remove horizon as well, analogously. Thanks!

> > Link: https://lore.kernel.org/all/20220321144013.440d7fc0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > ---
> > CC: myxie@...ian.org,gprocida@...ge.com
> > CC: Jesper Juhl <jj@...osbits.net>
> > CC: Dan Carpenter <dan.carpenter@...cle.com>
> > CC: Chas Williams <3chas3@...il.com> # ATM
> > CC: linux-atm-general@...ts.sourceforge.net
> > CC: tsbogend@...ha.franken.de # MIPS
> > CC: linux-mips@...r.kernel.org
> > CC: p.zabel@...gutronix.de # dunno why, get_maintainer
> > ---
> >  arch/mips/configs/gpr_defconfig  |    1 -
> >  arch/mips/configs/mtx1_defconfig |    1 -
> >  drivers/atm/Kconfig              |   25 -
> >  drivers/atm/Makefile             |    1 -
> >  drivers/atm/ambassador.c         | 2400 ------------------------------
> >  drivers/atm/ambassador.h         |  648 --------
> >  6 files changed, 3076 deletions(-)
> >  delete mode 100644 drivers/atm/ambassador.c
> >  delete mode 100644 drivers/atm/ambassador.h
>
> Acked-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
>

Acked-by: Giuliano Procida <gprocida@...gle.com>