netdev - Re: [PATCH] nfp: Remove kernel.h when not needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YpsjFwNv5s14sdhD@corigine.com>
Date:   Sat, 4 Jun 2022 11:17:11 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, oss-drivers@...igine.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] nfp: Remove kernel.h when not needed

On Sat, Jun 04, 2022 at 07:33:00AM +0200, Christophe JAILLET wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
> 
> Remove kernel.h when it is not needed.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Thanks for improving the NFP driver.

I think the contents of this patch looks good.

Reviewed-by: Simon Horman <simon.horman@...igine.com>

I also think this patch is appropriate for net-next
("[PATCH net-next] ..." in subject) and should thus be re-submitted
once net-next re-opens for the v5.20 development cycle, which I would
expect to happen in the coming days, after v5.19-rc1 has been released.

I'm happy to handle re-submitting it if you prefer.