netdev - Re: [PATCH] staging: wfx: Remove redundant NULL check before release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87leu7shv0.fsf@kernel.org>
Date:   Wed, 08 Jun 2022 11:02:27 +0300
From:   Kalle Valo <kvalo@...nel.org>
To:     Jérôme Pouiller <jerome.pouiller@...abs.com>
Cc:     cgel.zte@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] staging: wfx: Remove redundant NULL check before release_firmware() call

Jérôme Pouiller <jerome.pouiller@...abs.com> writes:

> On Monday 6 June 2022 03:42:37 CEST cgel.zte@...il.com wrote:
>> From: Minghao Chi <chi.minghao@....com.cn>
>> 
>> release_firmware() checks for NULL pointers internally so checking
>> before calling it is redundant.
>> 
>> Reported-by: Zeal Robot <zealci@....com.cn>
>> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>

[...]

> Signed-off-by: Jérôme Pouiller <jerome.pouiller@...abs.com>

I'll change this to Acked-by, s-o-b should be used only when you are
part of patch distribution:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

And please edit your quotes, otherwise using patchwork will be painful.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches