netdev - Re: [PATCH net-next 5/9] wireguard: use dev_sw_netstats_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Jun 2022 08:41:34 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 5/9] wireguard: use dev_sw_netstats_rx_add()

On Wed, Jun 8, 2022 at 12:36 AM Jason A. Donenfeld <Jason@...c4.com> wrote:
>
> Hi Eric,
>
> On Tue, Jun 07, 2022 at 04:36:10PM -0700, Eric Dumazet wrote:
> > From: Eric Dumazet <edumazet@...gle.com>
> >
> > We have a convenient helper, let's use it.
> > This will make the following patch easier to review and smaller.
> >
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > Cc: Jason A. Donenfeld <Jason@...c4.com>
>
> The subject line should be:
>
>     wireguard: receive: use dev_sw_netstats_rx_add()
>
> Please don't commit it before changing that. With that addressed,
>
>     Acked-by: Jason A. Donenfeld <Jason@...c4.com>
>

Got it, thanks.


> Regards,
> Jason
>
> >  drivers/net/wireguard/receive.c | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/drivers/net/wireguard/receive.c b/drivers/net/wireguard/receive.c
> > index 7b8df406c7737398f0270361afcb196af4b6a76e..7135d51d2d872edb66c856379ce2923b214289e9 100644
> > --- a/drivers/net/wireguard/receive.c
> > +++ b/drivers/net/wireguard/receive.c
> > @@ -19,15 +19,8 @@
> >  /* Must be called with bh disabled. */
> >  static void update_rx_stats(struct wg_peer *peer, size_t len)
> >  {
> > -     struct pcpu_sw_netstats *tstats =
> > -             get_cpu_ptr(peer->device->dev->tstats);
> > -
> > -     u64_stats_update_begin(&tstats->syncp);
> > -     ++tstats->rx_packets;
> > -     tstats->rx_bytes += len;
> > +     dev_sw_netstats_rx_add(peer->device->dev, len);
> >       peer->rx_bytes += len;
> > -     u64_stats_update_end(&tstats->syncp);
> > -     put_cpu_ptr(tstats);
> >  }
> >
> >  #define SKB_TYPE_LE32(skb) (((struct message_header *)(skb)->data)->type)
> > --
> > 2.36.1.255.ge46751e96f-goog
> >