netdev - Re: [PATCH] au1000_eth: stop using virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2+Y=dpFUSb+_u3sCdJ0kpkEF5JgAFP0T6CSDjrTFAusQ@mail.gmail.com>
Date:   Wed, 8 Jun 2022 20:19:55 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, Arnd Bergmann <arnd@...db.de>,
        Manuel Lauss <manuel.lauss@...il.com>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] au1000_eth: stop using virt_to_bus()

On Wed, Jun 8, 2022 at 8:01 PM Jakub Kicinski <kuba@...nel.org> wrote:
> On Tue,  7 Jun 2022 11:01:46 +0200 Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > The conversion to the dma-mapping API in linux-2.6.11 was incomplete
> > and left a virt_to_bus() call around. There have been a number of
> > fixes for DMA mapping API abuse in this driver, but this one always
> > slipped through.
> >
> > Change it to just use the existing dma_addr_t pointer, and make it
> > use the correct types throughout the driver to make it easier to
> > understand the virtual vs dma address spaces.
> >
> > Cc: Manuel Lauss <manuel.lauss@...il.com>
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Hi Arnd, this can go via net-next, right? The changes are simple
> enough, we can try to slip them into -rc2 if necessary.

It's probably fine either way. I hope to get the CONFIG_VIRT_TO_BUS
removal into v5.20, and if the final patch of that series comes before
this one, there will be a trivial bisection problem on mips/au1000, so
having it merged now would help.

        Arnd