netdev - Re: [PATCH net-next v6 2/3] net: phy: broadcom: Add PTP support for some Broadcom PHYs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220608205558.GB16693@hoboy.vegasvil.org>
Date:   Wed, 8 Jun 2022 13:55:58 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     netdev@...r.kernel.org, kernel-team@...com,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Lasse Johnsen <l@...johnsen.me>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH net-next v6 2/3] net: phy: broadcom: Add PTP support for
 some Broadcom PHYs.

On Wed, Jun 08, 2022 at 01:44:50PM -0700, Jonathan Lemon wrote:
> This adds PTP support for BCM54210E Broadcom PHYs, in particular,
> the BCM54213PE, as used in the Rasperry PI CM4.  It has only been
> tested on that hardware.

...

> +static const struct ptp_clock_info bcm_ptp_clock_info = {
> +	.owner		= THIS_MODULE,
> +	.name		= KBUILD_MODNAME,
> +	.max_adj	= 100000000,

Does this really work?  See below.

> +	.gettimex64	= bcm_ptp_gettimex,
> +	.settime64	= bcm_ptp_settime,
> +	.adjtime	= bcm_ptp_adjtime,
> +	.adjfine	= bcm_ptp_adjfine,
> +	.do_aux_work	= bcm_ptp_do_aux_work,
> +};

On another phy from the same (?) family (541xx), I found that the
synch becomes unstable when slewing more than:

	port->caps.max_adj	= 62500,

Thanks,
Richard