netdev - Re: [PATCH v1 net-next 4/5] ptp_ocp: do not call pci_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ec5fd68-a376-847a-2ad7-d352feea758c@novek.ru>
Date:   Wed, 8 Jun 2022 22:47:39 +0100
From:   Vadim Fedorenko <vfedorenko@...ek.ru>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH v1 net-next 4/5] ptp_ocp: do not call
 pci_set_drvdata(pdev, NULL)

On 08.06.2022 13:03, Andy Shevchenko wrote:
> Cleaning up driver data is actually already handled by driver core,
> so there is no need to do it manually.

I found a couple of places with exactly the same code in error path.
For example Marvell's OcteonX drivers in crypto and net subsystems.
Should we fix them too?

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Overall looks good.

Acked-by: Vadim Fedorenko <vfedorenko@...ek.ru>

> ---
>   drivers/ptp/ptp_ocp.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 4e237f806085..857e35c68a04 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -3769,7 +3769,6 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   
>   out:
>   	ptp_ocp_detach(bp);
> -	pci_set_drvdata(pdev, NULL);
>   out_disable:
>   	pci_disable_device(pdev);
>   out_free:
> @@ -3785,7 +3784,6 @@ ptp_ocp_remove(struct pci_dev *pdev)
>   
>   	devlink_unregister(devlink);
>   	ptp_ocp_detach(bp);
> -	pci_set_drvdata(pdev, NULL);
>   	pci_disable_device(pdev);
>   
>   	devlink_free(devlink);