netdev - Re: [PATCH net-next 1/7] Revert "net: set SK_MEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALvZod5g_Qev+0JzEHm+EGY08L7t_afwhnhtLwhVmkN-E7QqEA@mail.gmail.com>
Date:   Thu, 9 Jun 2022 08:08:51 -0700
From:   Shakeel Butt <shakeelb@...gle.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        netdev <netdev@...r.kernel.org>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Wei Wang <weiwan@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 1/7] Revert "net: set SK_MEM_QUANTUM to 4096"

On Wed, Jun 8, 2022 at 11:34 PM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
> From: Eric Dumazet <edumazet@...gle.com>
>
> This reverts commit bd68a2a854ad5a85f0c8d0a9c8048ca3f6391efb.
>
> This change broke memcg on arches with PAGE_SIZE != 4096
>
> Later, commit 2bb2f5fb21b04 ("net: add new socket option SO_RESERVE_MEM")
> also assumed PAGE_SIZE==SK_MEM_QUANTUM
>
> Following patches in the series will greatly reduce the over allocations
> problem.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Shakeel Butt <shakeelb@...gle.com>