netdev - Re: [PATCH iproute2-next v2] show rx_otherehost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 9 Jun 2022 14:07:26 -0700
From:   Jeffrey Ji <jeffreyjilinux@...il.com>
To:     David Ahern <dsahern@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     Brian Vazquez <brianvv@...gle.com>, netdev@...r.kernel.org,
        Jeffrey Ji <jeffreyji@...gle.com>
Subject: Re: [PATCH iproute2-next v2] show rx_otherehost_dropped stat in ip
 link show

sample output:

mypc[netns:ns-123771-2]:~# ip netns exec $ns2 ./ip -s -s link sh
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN
mode DEFAULT group default qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
RX: bytes packets errors dropped missed mcast
0 0 0 0 0 0
RX errors: length crc frame fifo overrun
0 0 0 0 0
TX: bytes packets errors dropped carrier collsns
0 0 0 0 0 0
TX errors: aborted fifo window heartbt transns
0 0 0 0 0
2: veth2@if2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue
state UP mode DEFAULT group default qlen 1000
link/ether 8e:c0:a5:7d:87:ad brd ff:ff:ff:ff:ff:ff link-netns ns-123771-1
RX: bytes packets errors dropped missed mcast
1766 22 0 0 0 0
RX errors: length crc frame fifo overrun otherhost
0 0 0 0 0 10
TX: bytes packets errors dropped carrier collsns
1126 13 0 0 0 0
TX errors: aborted fifo window heartbt transns
0 0 0 0 2

On Thu, Jun 9, 2022 at 2:05 PM Jeffrey Ji <jeffreyjilinux@...il.com> wrote:
>
> From: Jeffrey Ji <jeffreyji@...gle.com>
>
> This stat was added in commit 794c24e9921f ("net-core: rx_otherhost_dropped to core_stats")
>
> Tested: sent packet with wrong MAC address from 1
> network namespace to another, verified that counter showed "1" in
> `ip -s -s link sh` and `ip -s -s -j link sh`
>
> Signed-off-by: Jeffrey Ji <jeffreyji@...gle.com>
> ---
> changelog:
> v2: otherhost <- otherhost_dropped
>
>  ip/ipaddress.c | 18 +++++++++++++++---
>  1 file changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index 142731933ba3..d7d047cf901e 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -692,6 +692,7 @@ void print_stats64(FILE *fp, struct rtnl_link_stats64 *s,
>                 strlen("heartbt"),
>                 strlen("overrun"),
>                 strlen("compressed"),
> +               strlen("otherhost"),
>         };
>
>         if (is_json_context()) {
> @@ -730,6 +731,10 @@ void print_stats64(FILE *fp, struct rtnl_link_stats64 *s,
>                         if (s->rx_nohandler)
>                                 print_u64(PRINT_JSON,
>                                            "nohandler", NULL, s->rx_nohandler);
> +                       if (s->rx_otherhost_dropped)
> +                               print_u64(PRINT_JSON,
> +                                          "otherhost", NULL,
> +                                          s->rx_otherhost_dropped);
>                 }
>                 close_json_object();
>
> @@ -778,7 +783,8 @@ void print_stats64(FILE *fp, struct rtnl_link_stats64 *s,
>                         size_columns(cols, ARRAY_SIZE(cols), 0,
>                                      s->rx_length_errors, s->rx_crc_errors,
>                                      s->rx_frame_errors, s->rx_fifo_errors,
> -                                    s->rx_over_errors, s->rx_nohandler);
> +                                    s->rx_over_errors, s->rx_nohandler,
> +                                    s->rx_otherhost_dropped);
>                 size_columns(cols, ARRAY_SIZE(cols),
>                              s->tx_bytes, s->tx_packets, s->tx_errors,
>                              s->tx_dropped, s->tx_carrier_errors,
> @@ -811,11 +817,14 @@ void print_stats64(FILE *fp, struct rtnl_link_stats64 *s,
>                 /* RX error stats */
>                 if (show_stats > 1) {
>                         fprintf(fp, "%s", _SL_);
> -                       fprintf(fp, "    RX errors:%*s %*s %*s %*s %*s %*s %*s%s",
> +                       fprintf(fp, "    RX errors:%*s %*s %*s %*s %*s %*s%*s%*s%s",
>                                 cols[0] - 10, "", cols[1], "length",
>                                 cols[2], "crc", cols[3], "frame",
>                                 cols[4], "fifo", cols[5], "overrun",
> -                               cols[6], s->rx_nohandler ? "nohandler" : "",
> +                               s->rx_nohandler ? cols[6] + 1 : 0,
> +                               s->rx_nohandler ? " nohandler" : "",
> +                               s->rx_otherhost_dropped ? cols[7] + 1 : 0,
> +                               s->rx_otherhost_dropped ? " otherhost" : "",
>                                 _SL_);
>                         fprintf(fp, "%*s", cols[0] + 5, "");
>                         print_num(fp, cols[1], s->rx_length_errors);
> @@ -825,6 +834,9 @@ void print_stats64(FILE *fp, struct rtnl_link_stats64 *s,
>                         print_num(fp, cols[5], s->rx_over_errors);
>                         if (s->rx_nohandler)
>                                 print_num(fp, cols[6], s->rx_nohandler);
> +                       if (s->rx_otherhost_dropped)
> +                               print_num(fp, cols[7],
> +                               s->rx_otherhost_dropped);
>                 }
>                 fprintf(fp, "%s", _SL_);
>
> --
> 2.36.1.476.g0c4daa206d-goog
>