netdev - Re: [PATCH v1 net-next 4/5] ptp_ocp: do not call pci_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vejsx-mE2Pd3DarbWBABX0ceQAyOhUkUS3U8ns-xKShQQ@mail.gmail.com>
Date:   Thu, 9 Jun 2022 12:43:30 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Vadim Fedorenko <vfedorenko@...ek.ru>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH v1 net-next 4/5] ptp_ocp: do not call pci_set_drvdata(pdev,
 NULL)

On Thu, Jun 9, 2022 at 12:01 AM Vadim Fedorenko <vfedorenko@...ek.ru> wrote:
>
> On 08.06.2022 13:03, Andy Shevchenko wrote:
> > Cleaning up driver data is actually already handled by driver core,
> > so there is no need to do it manually.
>
> I found a couple of places with exactly the same code in error path.
> For example Marvell's OcteonX drivers in crypto and net subsystems.
> Should we fix them too?

I believe there are even more, but feel free to fix them, they are not my POI.

...

> Overall looks good.
>
> Acked-by: Vadim Fedorenko <vfedorenko@...ek.ru>

Thanks!

-- 
With Best Regards,
Andy Shevchenko