netdev - Re: [PATCH net-next v2 4/5] net: dsa: realtek: rtl8365mb: remove learn_limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220612105631.7fboskjgcf6oijor@bang-olufsen.dk>
Date:   Sun, 12 Jun 2022 10:56:32 +0000
From:   Alvin Šipraga <ALSI@...g-olufsen.dk>
To:     Luiz Angelo Daros de Luca <luizluca@...il.com>
CC:     Alvin Šipraga <alvin@...s.dk>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 4/5] net: dsa: realtek: rtl8365mb: remove
 learn_limit_max private data member

On Sat, Jun 11, 2022 at 10:40:33PM -0300, Luiz Angelo Daros de Luca wrote:
> > The variable is just assigned the value of a macro, so it can be
> > removed.
> 
> As I commented previously, the switches in this family with 10 ports
> do have a different value for RTL8365MB_LEARN_LIMIT_MAX.
> Once we add support for one of those models, we will somewhat revert this patch.

I wouldn't call that a revert, just normal development.

> 
> I believe learn_limit_max would fit better inside the new static
> chip_info structure.

Other pedants may ask me what the point of such a patch is when the hardware is
not even supported. That was my main reason for not incorporating your
suggestion.

The other reason is that, having actually experimented with the learn limit
myself, I could in fact make my RTL8365MB-VC learn more than this presupposed
maximum the vendor driver uses. I think it also depends on whether IVL/SVL is in
use. So there might be more to it than you think.