netdev - RE: [PATCH] vdpa: Add support for reading vdpa device statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM8PR12MB5400234FC1BCC7308163FE04ABAB9@DM8PR12MB5400.namprd12.prod.outlook.com>
Date:   Mon, 13 Jun 2022 05:59:57 +0000
From:   Eli Cohen <elic@...dia.com>
To:     David Ahern <dsahern@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "si-wei.liu@...cle.com" <si-wei.liu@...cle.com>,
        "mst@...hat.com" <mst@...hat.com>
Subject: RE: [PATCH] vdpa: Add support for reading vdpa device statistics

> From: David Ahern <dsahern@...nel.org>
> Sent: Thursday, June 9, 2022 6:11 PM
> To: Eli Cohen <elic@...dia.com>; netdev@...r.kernel.org; virtualization@...ts.linux-foundation.org; jasowang@...hat.com; si-
> wei.liu@...cle.com; mst@...hat.com
> Subject: Re: [PATCH] vdpa: Add support for reading vdpa device statistics
> 
> On 6/1/22 6:10 AM, Eli Cohen wrote:
> > diff --git a/vdpa/include/uapi/linux/vdpa.h b/vdpa/include/uapi/linux/vdpa.h
> > index cc575a825a7c..7f52e703f1ad 100644
> > --- a/vdpa/include/uapi/linux/vdpa.h
> > +++ b/vdpa/include/uapi/linux/vdpa.h
> > @@ -18,6 +18,7 @@ enum vdpa_command {
> >  	VDPA_CMD_DEV_DEL,
> >  	VDPA_CMD_DEV_GET,		/* can dump */
> >  	VDPA_CMD_DEV_CONFIG_GET,	/* can dump */
> > +	VDPA_CMD_DEV_STATS_GET,
> >  };
> >
> >  enum vdpa_attr {
> > @@ -46,6 +47,11 @@ enum vdpa_attr {
> >  	VDPA_ATTR_DEV_NEGOTIATED_FEATURES,	/* u64 */
> >  	VDPA_ATTR_DEV_MGMTDEV_MAX_VQS,		/* u32 */
> >  	VDPA_ATTR_DEV_SUPPORTED_FEATURES,	/* u64 */
> > +
> > +	VDPA_ATTR_DEV_QUEUE_INDEX,		/* u32 */
> > +	VDPA_ATTR_DEV_VENDOR_ATTR_NAME,		/* string */
> > +	VDPA_ATTR_DEV_VENDOR_ATTR_VALUE,	/* u64 */
> > +
> >  	/* new attributes must be added above here */
> >  	VDPA_ATTR_MAX,
> >  };
> 
> 
> no reference to the kernel patch, so I have no idea if this uapi has
> been committed to a kernel tree.

It has been merged upstream:

commit 13b00b135665c92065a27c0c39dd97e0f380bd4f
Author: Eli Cohen <elic@...dia.com>
Date:   Wed May 18 16:38:00 2022 +0300

    vdpa: Add support for querying vendor statistics

I am not sure what's the convention for reporting such reference.
In any case, I can repost the patch if you could let me know how I should write that reference.