netdev - RE: [PATCH, net] phy: aquantia: Fix AN when higher speeds than 1G are not advertised

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Jun 2022 14:08:30 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Heiner Kallweit <hkallweit1@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ondrej Spacek <ondrej.spacek@....com>
Subject: RE: [PATCH, net] phy: aquantia: Fix AN when higher speeds than 1G are
 not advertised

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Monday, June 13, 2022 12:25 AM
> To: Claudiu Manoil <claudiu.manoil@....com>
[...]
> Subject: Re: [PATCH, net] phy: aquantia: Fix AN when higher speeds than 1G
> are not advertised
> 
> > I understand the situation is not ideal. What I could do is to provide some
> > logs showing that writing the correct configuration to 7.20h does not yield
> > the desired result, to have some sort of detailed evidence about the issue.
> > But I cannot do that until Tuesday at the earliest.
> > As for documentation, there's an App Note about configuring advertising
> > via the vendor specific 0xC400 reg but I don't think it's public. Not sure if
> > we can use that.
> > Meanwhile, it would be great if you or someone else could confirm the
> > issue on a different platform.
> 
> I don't have any boards with these PHYs.
> 
> If there is a vendor document saying it has to be configured via
> vendor registers, thats enough for me. But should the generic code be
> removed, are those bits documented as reserved?
> 

Hi Andrew,

The generic code sets/clears the MDIO_AN_10GBT_CTRL_ADV2_5G,
MDIO_AN_10GBT_CTRL_ADV5G, MDIO_AN_10GBT_CTRL_ADV10G bits
in reg 7.20h correctly, as it should, if you're asking me. The App Note also
mentions that both registers, 7.20 and 7.c400, must be configured.
We're trying to reach the vendor for more details. You can hold off the
patch for now. Thanks.