netdev - Re: [PATCH v10 net-next 6/7] dt-bindings: mfd: ocelot: add bindings for VSC7512

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220614212735.GA592415@colin-ia-desktop>
Date:   Tue, 14 Jun 2022 14:27:35 -0700
From:   Colin Foster <colin.foster@...advantage.com>
To:     Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-gpio@...r.kernel.org,
        Vladimir Oltean <vladimir.oltean@....com>,
        Lee Jones <lee.jones@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Steen Hegelund <Steen.Hegelund@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        Linus Walleij <linus.walleij@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Terry Bowman <terry.bowman@....com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v10 net-next 6/7] dt-bindings: mfd: ocelot: add bindings
 for VSC7512

Hi Rob,

Thanks for the feedback! I'll include these changes in my next set.

On Tue, Jun 14, 2022 at 02:43:45PM -0600, Rob Herring wrote:
> On Fri, Jun 10, 2022 at 01:23:29PM -0700, Colin Foster wrote:
...
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - mscc,vsc7512-spi
> 
> '-spi' is redundant as we know what bus this is on looking at the 
> parent.
> 

Ahh... I see this now. A spi driver and an i2c driver (or otherwise)
can share the same compatible string, and the device tree sorts that
out for me. Thanks!

> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  "#address-cells":
> > +    const: 1
> > +
> > +  "#size-cells":
> > +    const: 0
> 
> No size? That's odd given the child nodes are the same as memory mapped 
> peripherals which expect a size.

This one has gone back and forth a couple times. The base addresses were
hard-coded in the driver and kept out of the device tree. But I couldn't
explicitly differentiate between mfd children "mdio0" and "mdio1" below,
so I recently added the address cells back in. This way mfd_cell->of_reg
and mfd_cell->use_of_reg can be used.

Unless suggested otherwise, I'll add size in here. As it is right now,
that size will be essentially ignored though. The resources (base and
size) are all defined in drivers/mfd/ocelot-core.c during the last patch
of this series.