netdev - RE: [PATCH 2/2] net/cdc_ncm: Add ntb_max_rx,ntb_max_tx cdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR03MB6533EB9ECD41DDA3B87FC371E1AA9@SJ0PR03MB6533.namprd03.prod.outlook.com>
Date:   Tue, 14 Jun 2022 05:47:47 +0000
From:   Lukasz Spintzyk <Lukasz.Spintzyk@...aptics.com>
To:     Oliver Neukum <oneukum@...e.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     PPD-POSIX <PPD-POSIX@...aptics.com>
Subject: RE: [PATCH 2/2] net/cdc_ncm: Add ntb_max_rx,ntb_max_tx cdc_ncm module
 parameters

This Is true, 
Some of Synaptics USB eth devices require values of TX and RX NTB size higher then 32kb and this is more then CDC_NCM_NTB_MAX_SIZE_TX/RX
I wanted to be careful an not increase limit of NTB size for all devices.  But it would also by ok to me if we could increase CDC_NCM_NTB_MAX_SIZE_TX/RX to 64kb.

Regards
Lukasz

-----Original Message-----
From: Oliver Neukum <oneukum@...e.com> 
Sent: Monday, June 13, 2022 4:54 PM
To: Lukasz Spintzyk <Lukasz.Spintzyk@...aptics.com>; netdev@...r.kernel.org
Cc: PPD-POSIX <PPD-POSIX@...aptics.com>
Subject: Re: [PATCH 2/2] net/cdc_ncm: Add ntb_max_rx,ntb_max_tx cdc_ncm module parameters

CAUTION: Email originated externally, do not click links or open attachments unless you recognize the sender and know the content is safe.

On 13.06.22 10:02, Łukasz Spintzyk wrote:
> This change allows to optionally adjust maximum RX and TX NTB size to 
> better match specific device capabilities, leading to higher 
> achievable Ethernet bandwidth.
>
Hi,

this is awkward a patch. If some devices need bigger buffers, the driver should grow its buffers for them without administrative intervention.

        Regards
                Oliver