netdev - Re: [PATCH v6] igb: Assign random MAC address instead of fail in case of invalid one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 15 Jun 2022 10:11:07 +0800
From:   梁礼学 <lianglixuehao@....com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Tony Nguyen <anthony.l.nguyen@...el.com>,
        Paul Menzel <pmenzel@...gen.mpg.de>,
        intel-wired-lan@...ts.osuosl.org,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Netdev <netdev@...r.kernel.org>,
        kernel test robot <lkp@...el.com>,
        lianglixue@...atwall.com.cn
Subject: Re: [PATCH v6] igb: Assign random MAC address instead of fail in case
 of invalid one

As alexander.duyck@...il.com said, "allow_unsupported_sfp" in ixgbe_main.c, 
and I also noticed "eeprom_bad_csum_allow" in e100.c, are all in the form of module parameters.

If the invalid MAC address is automatically replaced with a random MAC address, 
other problems caused by the random MAC address may be difficult to debug. 
Using module parameters can make it easy for users to correct invalid MAC addresses 
without causing the above problems

> 2022年6月15日 09:19，Jakub Kicinski <kuba@...nel.org> 写道：
> 
> On Tue, 14 Jun 2022 12:09:02 -0700 Tony Nguyen wrote:
>>> Add the module parameter "allow_invalid_mac_address" to control the  
>> 
>> netdev maintainers:
>> 
>> I know the use of module parameters is extremely frowned upon. Is this a 
>> use/exception that would be allowed?
> 
> I think so, I don't see a different way here.