netdev - Re: [PATCH net-next 02/15] net: phylink: add phylink_pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220615104652.591f5e98@kernel.org>
Date:   Wed, 15 Jun 2022 10:46:52 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Marek Behún <kabel@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org,
        Paolo Abeni <pabeni@...hat.com>,
        Robert Hancock <robert.hancock@...ian.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next 02/15] net: phylink: add phylink_pcs_inband()

On Wed, 15 Jun 2022 09:16:54 +0100 Russell King (Oracle) wrote:
> > Patch 1 does not need to be backported so I presume it can lose the
> > fixes tag?  
> 
> As the commit talks about fixing something, in my experience the commit
> will get automatically selected for backporting to stable trees whether
> or not it has a fixes tag on it. The only way to stop that happening is
> not through avoiding a fixes tag, but to keep on top of the stable tree
> emails to stop patches being backported that don't need to be.
> 
> If you still want me to remove it, I will, but I predict it will still
> be backported.

Fair, but the argument is not very... "clean", if you will. I read the
argument as "the unwelcome thing is likely to happen anyway, so doesn't
matter". But Fixes serves no purpose here, since we don't expect the
backport. So we are defaulting to adding something useless on the basis
of it not making things worse?

I'm only saying that to make sure I understand your perspective.
Obviously not something I'd hold your patches over, fine either way.