netdev - Re: [PATCH net-next v7 3/3] net: phy: Add support for 1PPS out and external timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220615022553.kkw7hoqm72r3yvmd@bsd-mbp>
Date:   Tue, 14 Jun 2022 19:25:53 -0700
From:   Jonathan Lemon <jonathan.lemon@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, kernel-team@...com,
        Andrew Lunn <andrew@...n.ch>,
        Richard Cochran <richardcochran@...il.com>,
        Lasse Johnsen <l@...johnsen.me>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH net-next v7 3/3] net: phy: Add support for 1PPS out and
 external timestamps

On Tue, Jun 14, 2022 at 09:25:38AM -0700, Florian Fainelli wrote:
> On 6/13/22 22:08, Jonathan Lemon wrote:
> > The perout function is used to generate a 1PPS signal, synchronized
> > to the PHC.  This is accomplished by a using the hardware oneshot
> > functionality, which is reset by a timer.
> > 
> > The external timestamp function is set up for a 1PPS input pulse,
> > and uses a timer to poll for temestamps.
> > 
> > Both functions use the SYNC_OUT/SYNC_IN1 pin, so cannot run
> > simultaneously.
> > 
> > Co-developed-by: Lasse Johnsen <l@...johnsen.me>
> > Signed-off-by: Lasse Johnsen <l@...johnsen.me>
> > Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>
> > Acked-by: Richard Cochran <richardcochran@...il.com>
> 
> Not sure whether we could apply just patch 1 and 2 and leave this one aside
> as I do see a few things that IMHO would be worth updating before merging
> this one, more on the stylistic aspect though, so you be the judge.

If you feel strongly about it, I can spin up some style fixes.

Personally, I prefer the simpler statements, and the compiler will
likely generate the same code.
-- 
Jonathan