netdev - Re: [PATCH net-next v3 2/2] net, neigh: introduce interval_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Jun 2022 16:33:03 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Nikolay Aleksandrov <razor@...ckwall.org>
Cc:     Yuwei Wang <wangyuweihx@...il.com>, davem@...emloft.net,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Daniel Borkmann <daniel@...earbox.net>, roopa@...dia.com,
        dsahern@...nel.org, 秦迪 <qindi@...ff.weibo.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/2] net, neigh: introduce
 interval_probe_time for periodic probe

On Wed, 15 Jun 2022 18:39:53 +0300 Nikolay Aleksandrov wrote:
> >> Do we need the proc entry to be in jiffies when the netlink option is in ms?
> >> Why not make it directly in ms (with _ms similar to other neigh _ms time options) ?
> >>
> >> IMO, it would be better to be consistent with the netlink option which sets it in ms.
> >>
> >> It seems the _ms options were added later and usually people want a more understandable
> >> value, I haven't seen anyone wanting a jiffies version of a ms interval variable. :)
> >>  
> >
> >It was in jiffies because this entry was separated from `DELAY_PROBE_TIME`,
> >it keeps nearly all the things the same as `DELAY_PROBE_TIME`,
> >they are both configured by seconds and read to jiffies, was `ms` in
> >netlink attribute,
> >I think it's ok to keep this consistency, and is there a demand
> >required to configure it by ms?
> >If there is that demand, we can make it configured as ms.
> 
> no, no demand, just out of user-friendliness :) but 
> I get it keeping it as jiffies is also fine 

+1 to using ms