netdev - Re: [PATCH net-next 02/15] net: phylink: add phylink_pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220614224652.09d4c287@kernel.org>
Date:   Tue, 14 Jun 2022 22:46:52 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Marek Behún <kabel@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org,
        Paolo Abeni <pabeni@...hat.com>,
        Robert Hancock <robert.hancock@...ian.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next 02/15] net: phylink: add phylink_pcs_inband()

On Mon, 13 Jun 2022 14:00:31 +0100 Russell King (Oracle) wrote:
> +	if (phylink_autoneg_inband(mode) &&
> +	    (interface == PHY_INTERFACE_MODE_SGMII ||
> +	     interface == PHY_INTERFACE_MODE_QSGMII ||
> +	     linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, advertising)))
> +		return true;
> +	else
> +		return false;

Okay, let me be a little annoying...

Could you run thru checkpatch --strict and fix the few whitespace
issues it points out? There's a handful of spaces instead of tabs,
unaligned continuation lines and an unnecessary bracket.

Patch 1 does not need to be backported so I presume it can lose the
fixes tag?

The quoted code can be converted into a direct return of the condition,
I don't really care but I think there are bots out there which will
send a "fix" soon if we commit this.

And patch 10 generates a transient "function should be static" warning.
I think you need a __maybe_unused on mv88e6xxx_pcs_select() as well.