netdev - Re: [RFC Patch net-next v2 12/15] net: dsa: microchip: ksz9477: separate phylink mode from switch register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yqm/Gb6icBxgBjcE@shell.armlinux.org.uk>
Date:   Wed, 15 Jun 2022 12:14:33 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Arun.Ramadoss@...rochip.com
Cc:     olteanv@...il.com, andrew@...n.ch, linux-kernel@...r.kernel.org,
        UNGLinuxDriver@...rochip.com, vivien.didelot@...il.com,
        f.fainelli@...il.com, kuba@...nel.org, edumazet@...gle.com,
        pabeni@...hat.com, netdev@...r.kernel.org,
        Woojung.Huh@...rochip.com, davem@...emloft.net
Subject: Re: [RFC Patch net-next v2 12/15] net: dsa: microchip: ksz9477:
 separate phylink mode from switch register

On Wed, Jun 15, 2022 at 08:49:46AM +0000, Arun.Ramadoss@...rochip.com wrote:
> On Tue, 2022-06-14 at 11:24 +0300, Vladimir Oltean wrote:
> > I wonder why the driver did not just remove these from the supported
> > mask in the phylink validation procedure in the first place?
> > Adding these link mode fixups to a dev_ops callback named "dsa_init"
> > does not sound quite right.
> 
> So, it means if the link modes are updated correctly in the
> phylink_get_caps then we don't need these link mode removal. Is my
> understanding correct?

Yes.

If you tell phylink what you support, then phylink will use that to
restrict what is supported by e.g. the PHY.

If you find that isn't the case, then I definitely want to know,
because that's probably a bug that needs to be fixed!

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!