netdev - Re: [PATCH net-next v5 3/5] net: pcs: xpcs: add CL37 1000BASE-X AN support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YqnBKTpbhx+quBIc@shell.armlinux.org.uk>
Date:   Wed, 15 Jun 2022 12:23:21 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Ong Boon Leong <boon.leong.ong@...el.com>
Cc:     Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <Jose.Abreu@...opsys.com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Paolo Abeni <pabeni@...hat.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Vladimir Oltean <olteanv@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Emilio Riva <emilio.riva@...csson.com>
Subject: Re: [PATCH net-next v5 3/5] net: pcs: xpcs: add CL37 1000BASE-X AN
 support

On Wed, Jun 15, 2022 at 04:39:06PM +0800, Ong Boon Leong wrote:
> For CL37 1000BASE-X AN, DW xPCS does not support C22 method but offers
> C45 vendor-specific MII MMD for programming.
> 
> We also add the ability to disable Autoneg (through ethtool for certain
> network switch that supports 1000BASE-X (1000Mbps and Full-Duplex) but
> not Autoneg capability.
> 
> v4: Fixes to comment from Russell King. Thanks!
>     https://patchwork.kernel.org/comment/24894239/
>     Make xpcs_modify_changed() as private, change to use
>     mdiodev_modify_changed() for cleaner code.
> 
> v3: Fixes to issues spotted by Russell King. Thanks!
>     https://patchwork.kernel.org/comment/24890210/
>     Use phylink_mii_c22_pcs_decode_state(), remove unnecessary
>     interrupt clearing and skip speed & duplex setting if AN
>     is enabled.
> 
> v2: Fixes to issues spotted by Russell King in v1. Thanks!
>     https://patchwork.kernel.org/comment/24826650/
>     Use phylink_mii_c22_pcs_encode_advertisement() and implement
>     C45 MII ADV handling since IP only support C45 access.
> 
> Tested-by: Emilio Riva <emilio.riva@...csson.com>
> Signed-off-by: Ong Boon Leong <boon.leong.ong@...el.com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!