netdev - Re: [iproute2-next v1] seg6: add support for flavors in SRv6 End* behaviors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220616184506.Horde.7w03-P-A-1f4D_CFSrrRzEi@webmail.uniroma2.it>
Date:   Thu, 16 Jun 2022 18:45:06 +0200
From:   Paolo Lungaroni <paolo.lungaroni@...roma2.it>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        Stefano Salsano <stefano.salsano@...roma2.it>,
        Ahmed Abdelsalam <ahabdels.dev@...il.com>,
        Andrea Mayer <andrea.mayer@...roma2.it>
Subject: Re: [iproute2-next v1] seg6: add support for flavors in SRv6 End*
 behaviors

Hi Stephen,
Thanks for your review. Please see my answers inline.

Stephen Hemminger <stephen@...workplumber.org> ha scritto:

> On Sat, 11 Jun 2022 13:06:45 +0200
> Paolo Lungaroni <paolo.lungaroni@...roma2.it> wrote:
>
>> +	strlcpy(wbuf, buf, SEG6_LOCAL_FLV_BUF_SIZE);
>> +	wbuf[SEG6_LOCAL_FLV_BUF_SIZE - 1] = 0;
>> +
>> +	if (strlen(wbuf) == 0)
>> +		return -1;
>
> If you use strdupa() then you don't have to worry about buffer sizes.

Yes sure, I will use it in the v2.

>
> +			else {
> +				if (fnumber++ == 0)
> +					fprintf(fp, "%s", flv_name);
> +				else
> +					fprintf(fp, ",%s", flv_name);
> +			}
>
> Minor nits. I am trying to get rid of use of passing fp around
> and just use print_string() everywhere. That way can do quick scan
> for places still using 'fprintf(fp' as indicator of old code
> that was never updated to use JSON.

Ok, substituting 'fprintf(fp' with print_string() is not a problem.

>
> Also, it looks the output of multiple flavors does not match
> the input command line for multiple flavors.

If you refer to the order, this is intentional as the user can add
flavors in any order, but they will be printed in a "canonical" order.

If it's not the order, can you clarify which is the problem?

Thanks for your suggestions,

Paolo.