netdev - Re: [PATCH net] Revert "net: Add a second bind table hashed by port and address"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+Gf_xbz_df21QSM8ddjKkFfk1h4Y=p4vHroPRAz0ZYrw@mail.gmail.com>
Date:   Wed, 15 Jun 2022 23:24:01 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Joanne Koong <joannelkoong@...il.com>
Cc:     netdev <netdev@...r.kernel.org>, Martin KaFai Lau <kafai@...com>,
        Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>
Subject: Re: [PATCH net] Revert "net: Add a second bind table hashed by port
 and address"

On Wed, Jun 15, 2022 at 12:32 PM Joanne Koong <joannelkoong@...il.com> wrote:
>
> This reverts:
>
> commit d5a42de8bdbe ("net: Add a second bind table hashed by port and address")
> commit 538aaf9b2383 ("selftests: Add test for timing a bind request to a port with a populated bhash entry")
> Link: https://lore.kernel.org/netdev/20220520001834.2247810-1-kuba@kernel.org/
>
> There are a few things that need to be fixed here:
> * Updating bhash2 in cases where the socket's rcv saddr changes
> * Adding bhash2 hashbucket locks
>
> Links to syzbot reports:
> https://lore.kernel.org/netdev/00000000000022208805e0df247a@google.com/
> https://lore.kernel.org/netdev/0000000000003f33bc05dfaf44fe@google.com/
>
> Fixes: d5a42de8bdbe ("net: Add a second bind table hashed by port and address")
> Signed-off-by: Joanne Koong <joannelkoong@...il.com>
> ---


Do we really need to remove the test ? It is a benchmark, and should
not 'fail' on old kernels.