netdev - Re: [PATCH net-next 1/1] net: wwan: t7xx: Add AP CLDMA and GNSS port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb56f67-7353-39c7-a3fa-a237e15f3b95@linux.intel.com>
Date:   Thu, 16 Jun 2022 12:37:05 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Moises Veleta <moises.veleta@...ux.intel.com>
cc:     Netdev <netdev@...r.kernel.org>, kuba@...nel.org,
        davem@...emloft.net, johannes@...solutions.net,
        ryazanov.s.a@...il.com, loic.poulain@...aro.org,
        m.chetan.kumar@...el.com, chandrashekar.devegowda@...el.com,
        linuxwwan@...el.com, chiranjeevi.rapolu@...ux.intel.com,
        haijun.liu@...iatek.com, ricardo.martinez@...ux.intel.com,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        dinesh.sharma@...el.com, moises.veleta@...el.com,
        Madhusmita Sahu <madhusmita.sahu@...el.com>
Subject: Re: [PATCH net-next 1/1] net: wwan: t7xx: Add AP CLDMA and GNSS
 port

On Tue, 14 Jun 2022, Moises Veleta wrote:

> From: Haijun Liu <haijun.liu@...iatek.com>
> 
> The t7xx device contains two Cross Layer DMA (CLDMA) interfaces to
> communicate with AP and Modem processors respectively. So far only
> MD-CLDMA was being used, this patch enables AP-CLDMA and the GNSS
> port which requires such channel.
> 
> Signed-off-by: Haijun Liu <haijun.liu@...iatek.com>
> Co-developed-by: Madhusmita Sahu <madhusmita.sahu@...el.com>
> Signed-off-by: Madhusmita Sahu <madhusmita.sahu@...el.com>
> Signed-off-by: Moises Veleta <moises.veleta@...ux.intel.com>
> ---

Look fine to me. One nit below.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

> diff --git a/drivers/net/wwan/t7xx/t7xx_port.h b/drivers/net/wwan/t7xx/t7xx_port.h
> index dc4133eb433a..3d27f04e2a1f 100644
> --- a/drivers/net/wwan/t7xx/t7xx_port.h
> +++ b/drivers/net/wwan/t7xx/t7xx_port.h
> @@ -36,9 +36,17 @@
>  /* Channel ID and Message ID definitions.
>   * The channel number consists of peer_id(15:12) , channel_id(11:0)
>   * peer_id:
> - * 0:reserved, 1: to sAP, 2: to MD
> + * 0:reserved, 1: to AP, 2: to MD
>   */
>  enum port_ch {
> +	/* to AP */
> +	PORT_CH_AP_CONTROL_RX = 0X1000,
> +	PORT_CH_AP_CONTROL_TX = 0X1001,

Please use lowercase x.


-- 
 i.