netdev - Re: [PATCH net] igb: fix a use-after-free issue in igb_clean_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Jun 2022 16:36:56 +0200
From:   Jesper Dangaard Brouer <jbrouer@...hat.com>
To:     Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>, netdev@...r.kernel.org,
        davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com
Cc:     brouer@...hat.com, anthony.l.nguyen@...el.com, edumazet@...gle.com,
        intel-wired-lan@...ts.osuosl.org, lorenzo.bianconi@...hat.com,
        magnus.karlsson@...el.com, sven.auhagen@...eatech.de
Subject: Re: [PATCH net] igb: fix a use-after-free issue in igb_clean_tx_ring



On 16/06/2022 20.26, Jesse Brandeburg wrote:
> On 6/16/2022 7:13 AM, Lorenzo Bianconi wrote:
>> Fix the following use-after-free bug in igb_clean_tx_ring routine when
>> the NIC is running in XDP mode. The issue can be triggered redirecting
>> traffic into the igb NIC and then closing the device while the traffic
>> is flowing.
> 
> <snip>
> 
>>
>> Fixes: 9cbc948b5a20c ("igb: add XDP support")
>> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> 
> Thanks Lorenzo, @maintainers this fix seems simple enough you could 
> directly apply it without going through intel-wired-lan, once you think 
> it's ready.
> 
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 

Sounds good to me.

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>