netdev - RE: [Patch bpf-next v4 0/4] sockmap: some performance optimizations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62ad2b02627ce_24b342089f@john.notmuch>
Date:   Fri, 17 Jun 2022 18:31:46 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc:     bpf@...r.kernel.org, Cong Wang <cong.wang@...edance.com>
Subject: RE: [Patch bpf-next v4 0/4] sockmap: some performance optimizations

Cong Wang wrote:
> From: Cong Wang <cong.wang@...edance.com>
> 
> This patchset contains two optimizations for sockmap. The first one
> eliminates a skb_clone() and the second one eliminates a memset(). With
> this patchset, the throughput of UDP transmission via sockmap gets
> improved by 61%.
> 
> v4: replace kfree_skb() with consume_skb()
> 
> v3: avoid touching tcp_recv_skb()
> 
> v2: clean up coding style for tcp_read_skb()
>     get rid of some redundant variables
>     add a comment for ->read_skb()
> ---
> Cong Wang (4):
>   tcp: introduce tcp_read_skb()
>   net: introduce a new proto_ops ->read_skb()
>   skmsg: get rid of skb_clone()
>   skmsg: get rid of unncessary memset()
> 
>  include/linux/net.h |  4 ++++
>  include/net/tcp.h   |  1 +
>  include/net/udp.h   |  3 +--
>  net/core/skmsg.c    | 48 +++++++++++++++++----------------------------
>  net/ipv4/af_inet.c  |  3 ++-
>  net/ipv4/tcp.c      | 44 +++++++++++++++++++++++++++++++++++++++++
>  net/ipv4/udp.c      | 11 +++++------
>  net/ipv6/af_inet6.c |  3 ++-
>  net/unix/af_unix.c  | 23 +++++++++-------------
>  9 files changed, 86 insertions(+), 54 deletions(-)
> 
> -- 
> 2.34.1
> 

Thanks Cong, nice set of improvements.

Reviewed-by: John Fastabend <john.fastabend@...il.com>