netdev - Re: [net-next PATCH] net: ethernet: stmmac: remove select QCOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Jun 2022 11:49:31 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Christian Marangi <ansuelsmth@...il.com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Networking <netdev@...r.kernel.org>,
        linux-stm32@...md-mailman.stormreply.com,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [net-next PATCH] net: ethernet: stmmac: remove select
 QCOM_SOCINFO and make it optional

On Fri, Jun 17, 2022 at 12:15 AM Christian Marangi <ansuelsmth@...il.com> wrote:
>
> QCOM_SOCINFO depends on QCOM_SMEM but is not selected, this cause some
> problems with QCOM_SOCINFO getting selected with the dependency of
> QCOM_SMEM not met.
> To fix this remove the select in Kconfig and add additional info in the
> DWMAC_IPQ806X config description.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 9ec092d2feb6 ("net: ethernet: stmmac: add missing sgmii configure for ipq806x")
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> index c4bca16dae57..31ff35174034 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -83,7 +83,6 @@ config DWMAC_IPQ806X
>         default ARCH_QCOM
>         depends on OF && (ARCH_QCOM || COMPILE_TEST)
>         select MFD_SYSCON
> -       select QCOM_SOCINFO
>         help
>           Support for QCA IPQ806X DWMAC Ethernet.
>
> @@ -92,6 +91,9 @@ config DWMAC_IPQ806X
>           acceleration features available on this SoC. Network devices
>           will behave like standard non-accelerated ethernet interfaces.
>
> +         Select the QCOM_SOCINFO config flag to enable specific dwmac
> +         fixup based on the ipq806x SoC revision.

I think the correct way would have been to use

     depends on QCOM_SOCINFO || COMPILE_TEST

here.

        Arnd