netdev - Re: [net-next: PATCH 04/12] net: mvpp2: initialize port fwnode pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrCx5SkADWBzRokM@smile.fi.intel.com>
Date:   Mon, 20 Jun 2022 20:44:05 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Marcin Wojtas <mw@...ihalf.com>
Cc:     linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        netdev@...r.kernel.org, rafael@...nel.org, lenb@...nel.org,
        andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com,
        olteanv@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk,
        hkallweit1@...il.com, gjb@...ihalf.com, jaz@...ihalf.com,
        tn@...ihalf.com, Samer.El-Haj-Mahmoud@....com,
        upstream@...ihalf.com
Subject: Re: [net-next: PATCH 04/12] net: mvpp2: initialize port fwnode
 pointer

On Mon, Jun 20, 2022 at 08:43:05PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 20, 2022 at 05:02:17PM +0200, Marcin Wojtas wrote:
> > As a preparation to switch the DSA subsystem from using
> > of_find_net_device_by_node() to its more generic fwnode_
> > equivalent, the port's device structure should be updated
> > with its fwnode pointer, similarly to of_node - see analogous
> > commit c4053ef32208 ("net: mvpp2: initialize port of_node pointer").
> > 
> > This patch is required to prevent a regression before updating
> > the DSA API on boards that connect the mvpp2 port to switch,
> > such as Clearfog GT-8K or CN913x CEx7 Evaluation Board.
> 
> ...
> 
> >  	dev->dev.of_node = port_node;
> > +	dev->dev.fwnode = port_fwnode;
> 
> device_set_node() ?

Ah, important remark to all device_set_node() comments. It assumes that you
replace _both_ assignments with _single_ call.

-- 
With Best Regards,
Andy Shevchenko