netdev - Re: [PATCH net] net/tls: fix tls_sk_proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220620111808.5b313aa6@kernel.org>
Date:   Mon, 20 Jun 2022 11:18:08 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     patchwork-bot+netdevbpf@...nel.org
Cc:     Ziyang Xuan <william.xuanziyang@...wei.com>, borisp@...dia.com,
        john.fastabend@...il.com, daniel@...earbox.net,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net/tls: fix tls_sk_proto_close executed repeatedly

On Mon, 20 Jun 2022 09:20:12 +0000 patchwork-bot+netdevbpf@...nel.org
wrote:
> On Mon, 20 Jun 2022 12:35:08 +0800 you wrote:
> > After setting the sock ktls, update ctx->sk_proto to sock->sk_prot by
> > tls_update(), so now ctx->sk_proto->close is tls_sk_proto_close(). When
> > close the sock, tls_sk_proto_close() is called for sock->sk_prot->close
> > is tls_sk_proto_close(). But ctx->sk_proto->close() will be executed later
> > in tls_sk_proto_close(). Thus tls_sk_proto_close() executed repeatedly
> > occurred. That will trigger the following bug.
> > 
> > [...]  
> 
> Here is the summary with links:
>   - [net] net/tls: fix tls_sk_proto_close executed repeatedly
>     https://git.kernel.org/netdev/net/c/69135c572d1f

No, this is not the right fix. The AF_UNIX restructuring has moved the
ULP check too late. I'll send a revert and the correct fix.