netdev - Re: [PATCH net-next v8 2/3] net: phy: broadcom: Add PTP support for some Broadcom PHYs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220620224517.wv2qecwxjkqfvayd@bsd-mbp.dhcp.thefacebook.com>
Date:   Mon, 20 Jun 2022 15:45:17 -0700
From:   Jonathan Lemon <jonathan.lemon@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, kernel-team@...com,
        Andrew Lunn <andrew@...n.ch>,
        Richard Cochran <richardcochran@...il.com>,
        Lasse Johnsen <l@...johnsen.me>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH net-next v8 2/3] net: phy: broadcom: Add PTP support for
 some Broadcom PHYs.

On Sat, Jun 18, 2022 at 05:48:46PM +0800, kernel test robot wrote:
> Hi Jonathan,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on net-next/master]

Upcoming fix:

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 2f299ef26a27..4bb231013009 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -105,6 +105,7 @@ config BROADCOM_PHY
        tristate "Broadcom 54XX PHYs"
        select BCM_NET_PHYLIB
        select BCM_NET_PHYPTP if NETWORK_PHY_TIMESTAMPING
+       depends on PTP_1588_CLOCK_OPTIONAL
        help
          Currently supports the BCM5411, BCM5421, BCM5461, BCM54616S, BCM5464,
          BCM5481, BCM54810 and BCM5482 PHYs.
@@ -163,7 +164,6 @@ config BCM_NET_PHYLIB

 config BCM_NET_PHYPTP
        tristate
-       depends on PTP_1588_CLOCK_OPTIONAL

 config CICADA_PHY
        tristate "Cicada PHYs"


Since apparently rules under "select" are not transitive.

Florian - before I repost this, any other changes to patch #3?
--
Jonathan