netdev - Re: [PATCH 5.10 2/2] commit 1b5d73fb8624 ("igc: Enable PCIe PTM")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Jun 2022 13:56:51 +0200
From:   Greg KH <greg@...ah.com>
To:     Meng Tang <tangmeng@...ontech.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        Dvora Fuxbrumer <dvorax.fuxbrumer@...ux.intel.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>
Subject: Re: [PATCH 5.10 2/2] commit 1b5d73fb8624 ("igc: Enable PCIe PTM")

On Tue, Jun 14, 2022 at 09:15:28AM +0800, Meng Tang wrote:
> In the 5.10 kernel version, even to the latest confirmed version,
> the following error will still be reported when I225-V network card
> is used.
> 
> kernel: [    1.031581] igc: probe of 0000:01:00.0 failed with error -2
> kernel: [    1.066574] igc: probe of 0000:02:00.0 failed with error -2
> kernel: [    1.096152] igc: probe of 0000:03:00.0 failed with error -2
> kernel: [    1.127251] igc: probe of 0000:04:00.0 failed with error -2
> 
> Even though I confirmed that 7c496de538eebd8212dc2a3c9a468386b2640d4
> and 47bca7de6a4fb8dcb564c7ca4d885c91ed19e03 have been merged into the
> kernel 5.10, but bug still occurred, and this patch can fixes it.
> 
> Enables PCIe PTM (Precision Time Measurement) support in the igc
> driver. Notifies the PCI devices that PCIe PTM should be enabled.
> 
> PCIe PTM is similar protocol to PTP (Precision Time Protocol) running
> in the PCIe fabric, it allows devices to report time measurements from
> their internal clocks and the correlation with the PCIe root clock.
> 
> The i225 NIC exposes some registers that expose those time
> measurements, those registers will be used, in later patches, to
> implement the PTP_SYS_OFFSET_PRECISE ioctl().
> 
> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@...ux.intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> Signed-off-by: Meng Tang <tangmeng@...ontech.com>
> ---
>  drivers/net/ethernet/intel/igc/igc_main.c | 5 +++++
>  1 file changed, 5 insertions(+)

Both now queued up, thanks.

greg k-h