netdev - Re: [PATCH v3] net: usb: ax88179_178a: Bind only to vendor-specific interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Jun 2022 14:33:57 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Hector Martin <marcan@...can.st>,
        Jacky Chou <jackychou@...x.com.tw>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] net: usb: ax88179_178a: Bind only to vendor-specific
 interface



On 21.06.22 12:21, Hector Martin wrote:
> The Anker PowerExpand USB-C to Gigabit Ethernet adapter uses this
> chipset, but exposes CDC Ethernet configurations as well as the
> vendor specific one. This driver ends up binding first to both CDC
> interfaces, tries to instantiate two Ethernet interfaces talking to
> the same device, and the result is a nice fireworks show.

Could you explicitly state here that the root cause is that the
driver for the vendor specific mode binds to the device based only
on vendor:product ID, thus taking interfaces that only the
class driver can handle properly?

This log reads like the basic issue is that it binds to two
interfaces.

The patch itself is fine.

	Regards
		Oliver