netdev - Re: [PATCH net-next v2] net: pcs: xpcs: select PHYLINK in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Jun 2022 15:35:05 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Ong Boon Leong <boon.leong.ong@...el.com>
Subject: Re: [PATCH net-next v2] net: pcs: xpcs: select PHYLINK in Kconfig

On Wed, Jun 22, 2022 at 04:31:56PM +0200, Paolo Abeni wrote:
> This is another attempt at fixing:
> 
> >> ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
> >> ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!
> 
> We can't mix select and depends, or that will trigger a circular dependency.
> We can't use 'depends on' for PHYLINK, as the latter config is not
> user-visible.
> Pull-in all the dependencies via 'select'.
> Note that PHYLINK already selects PHYLIB, which in turn selects MDIO_DEVICE.
> 
> v1 -> v2:
>  - use 'select' instead of 'depends on' (Jakub)

Why? I'm failing to understand the rationale here. See my reply to
Jakub sent a few minutes ago.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!