lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220621220955.73e4e1fc@kernel.org>
Date:   Tue, 21 Jun 2022 22:09:55 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Martin Habets <habetsm.xilinx@...il.com>
Cc:     jonathan.s.cooper@....com, davem@...emloft.net, pabeni@...hat.com,
        edumazet@...gle.com, netdev@...r.kernel.org, ecree.xilinx@...il.com
Subject: Re: [PATCH net-next 8/8] sfc: Separate netdev probe/remove from PCI
 probe/remove

On Mon, 20 Jun 2022 14:59:51 +0100 Martin Habets wrote:
> From: Jonathan Cooper <jonathan.s.cooper@....com>
> 
> The netdev probe will be used when moving from the vDPA to EF100 BAR config.
> The netdev remove will be used when moving from the EF100 to vDPA BAR config.
> 
> In the process, change several log messages to pci_ instead of netif_
> to remove the "(unregistered net_device)" text.

The patches LGTM, but this one needs to get checkpatch'ed. 
Whitespace is off. Sorry for not catching this earlier.
Consider switching from the non-standard Co-authored-by 
to Co-developed-by for extra points.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ