netdev - Re: [PATCH] cxgb4: DOM support when using a QSFP to SFP adaptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220621222317.1cbcaaeb@kernel.org>
Date:   Tue, 21 Jun 2022 22:23:17 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Arthur Gautier <baloo@...erbaloo.net>
Cc:     Raju Rangoju <rajur@...lsio.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] cxgb4: DOM support when using a QSFP to SFP adaptor

On Mon, 20 Jun 2022 22:32:34 +0000 Arthur Gautier wrote:
> When a QSFP to SFP adaptor is used, the DOM eeprom is then presented
> with the SFF-8472 layout and not translated to SFF-8636 format.
> 
> When parsing the eeprom, we can't just read the type of port but we
> need to identify the type of transceiver instead.
> 
> Signed-off-by: Arthur Gautier <baloo@...erbaloo.net>
> Cc: Raju Rangoju <rajur@...lsio.com>
> Cc: netdev@...r.kernel.org

Makes sense. Do you expect this change to make it into the long term
stable branches or are you okay with it appearing starting with 5.20?

> +#define SFF_8636_ID		0x0
> +#define SFF_8636_ID_LEN	0x1
> +#define SFF_8024_ID_SFP	0x3

Please use the defines from include/linux/sfp.h
SFF8024_ID_SFP and SFP_PHYS_ID