netdev - RE: [PATCH v5 2/5] bpf: Add bpf_lookup_user_key() and bpf_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <796b55c79be142cab6a22dd281fdb9fa@huawei.com>
Date:   Wed, 22 Jun 2022 07:12:02 +0000
From:   Roberto Sassu <roberto.sassu@...wei.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
CC:     "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "andrii@...nel.org" <andrii@...nel.org>,
        "kpsingh@...nel.org" <kpsingh@...nel.org>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "songliubraving@...com" <songliubraving@...com>,
        "kafai@...com" <kafai@...com>, "yhs@...com" <yhs@...com>,
        "dhowells@...hat.com" <dhowells@...hat.com>,
        "keyrings@...r.kernel.org" <keyrings@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5 2/5] bpf: Add bpf_lookup_user_key() and bpf_key_put()
 helpers

> From: Alexei Starovoitov [mailto:alexei.starovoitov@...il.com]
> Sent: Wednesday, June 22, 2022 12:33 AM
> On Tue, Jun 21, 2022 at 06:37:54PM +0200, Roberto Sassu wrote:
> > Add the bpf_lookup_user_key() and bpf_key_put() helpers, to respectively
> > search a key with a given serial, and release the reference count of the
> > found key.
> >
> > Signed-off-by: Roberto Sassu <roberto.sassu@...wei.com>
> > ---
> >  include/uapi/linux/bpf.h       | 16 ++++++++++++
> >  kernel/bpf/bpf_lsm.c           | 46 ++++++++++++++++++++++++++++++++++
> >  kernel/bpf/verifier.c          |  6 +++--
> >  scripts/bpf_doc.py             |  2 ++
> >  tools/include/uapi/linux/bpf.h | 16 ++++++++++++
> >  5 files changed, 84 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> > index e81362891596..7bbcf2cd105d 100644
> > --- a/include/uapi/linux/bpf.h
> > +++ b/include/uapi/linux/bpf.h
> > @@ -5325,6 +5325,20 @@ union bpf_attr {
> >   *		**-EACCES** if the SYN cookie is not valid.
> >   *
> >   *		**-EPROTONOSUPPORT** if CONFIG_IPV6 is not builtin.
> > + *
> > + * struct key *bpf_lookup_user_key(u32 serial, unsigned long flags)
> > + *	Description
> > + *		Search a key with a given *serial* and the provided *flags*, and
> > + *		increment the reference count of the key.
> 
> Why passing 'flags' is ok to do?
> Please think through every line of the patch.

To be honest, I thought about it. Probably yes, I should do some
sanitization, like I did for the keyring ID. When I checked
lookup_user_key(), I saw that flags are checked individually, so
an arbitrary value passed to the helper should not cause harm.
Will do sanitization, if you prefer. It is just that we have to keep
the eBPF code in sync with key flag definition (unless we have
a 'last' flag).

Thanks

Roberto

HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Li Peng, Yang Xi, Li He