netdev - Re: [PATCH ipsec-next] xfrm: no need to set DST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220623104838.GC566407@gauss3.secunet.de>
Date:   Thu, 23 Jun 2022 12:48:38 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
CC:     Eyal Birger <eyal.birger@...il.com>, <dsahern@...nel.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <yoshfuji@...ux-ipv6.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <shmulik.ladkani@...il.com>
Subject: Re: [PATCH ipsec-next] xfrm: no need to set DST_NOPOLICY in IPv4

On Fri, May 20, 2022 at 02:01:19PM +0200, Nicolas Dichtel wrote:
> 
> Le 20/05/2022 à 12:48, Eyal Birger a écrit :
> > This is a cleanup patch following commit e6175a2ed1f1
> > ("xfrm: fix "disable_policy" flag use when arriving from different devices")
> > which made DST_NOPOLICY no longer be used for inbound policy checks.
> > 
> > On outbound the flag was set, but never used.
> > 
> > As such, avoid setting it altogether and remove the nopolicy argument
> > from rt_dst_alloc().
> > 
> > Signed-off-by: Eyal Birger <eyal.birger@...il.com>
> Reviewed-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Now applied to ipsec-next, thanks everyone!