netdev - Re: [PATCH net 1/2] net/sched: act_api: Notify user space if any actions were flushed before error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMmpP2V75BXZa0_-jKFARumoT4R_6p3_Bk0T90kNnxrVxg@mail.gmail.com>
Date:   Thu, 23 Jun 2022 11:10:33 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Victor Nogueira <victor@...atatu.com>
Cc:     Cong Wang <xiyou.wangcong@...il.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net 1/2] net/sched: act_api: Notify user space if any
 actions were flushed before error

On Thu, Jun 23, 2022 at 10:08 AM Victor Nogueira <victor@...atatu.com> wrote:
>
> If during an action flush operation one of the actions is still being
> referenced, the flush operation is aborted and the kernel returns to
> user space with an error. However, if the kernel was able to flush, for
> example, 3 actions and failed on the fourth, the kernel will not notify
> user space that it deleted 3 actions before failing.
>
> This patch fixes that behaviour by notifying user space of how many
> actions were deleted before flush failed and by setting extack with a
> message describing what happened.
>
> Fixes: 55334a5db5cd ("net_sched: act: refuse to remove bound action outside")
>
> Signed-off-by: Victor Nogueira <victor@...atatu.com>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal