netdev - Re: [PATCH] mlxsw: drop unexpected word 'for' in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220623092208.1abbd9dc@kernel.org>
Date:   Thu, 23 Jun 2022 09:22:08 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiang Jian <jiangjian@...rlc.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        idosch@...dia.com, petrm@...dia.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mlxsw: drop unexpected word 'for' in comments

On Thu, 23 Jun 2022 18:46:01 +0800 Jiang Jian wrote:
> file - drivers/net/ethernet/mellanox/mlxsw/spectrum2_kvdl.c
> line - 18
> 
> 	 * ids for for this purpose in partition definition.
> changed to:
> 
> 	 * ids for this purpose in partition definition.

Please stop putting the change into the description.
I think I already complained about this.
This is exactly the same information as is in the patch itself.

And as other people have pointed out - please say that the word
is repeated not "unexpected".

IDK why you made those changes because your patches on Wednesday 
where better:

  [PATCH] bnxt: Fix typo in comments

  Remove the repeated word 'and' from comments

  Signed-off-by: Jiang Jian <jiangjian@...rlc.com>

https://lore.kernel.org/r/20220622144526.20659-1-jiangjian@cdjrlc.com/

I'm dropping these patches from you, please redo them:

  https://patchwork.kernel.org/project/netdevbpf/patch/20220623104919.49600-1-jiangjian@cdjrlc.com/
  https://patchwork.kernel.org/project/netdevbpf/patch/20220622171711.6969-1-jiangjian@cdjrlc.com/
  https://patchwork.kernel.org/project/netdevbpf/patch/20220623104601.48149-1-jiangjian@cdjrlc.com/