netdev - Re: [PATCH v3 0/2] net: dp83822: fix interrupt floods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Jun 2022 20:24:18 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Enguerrand de Ribaucourt 
        <enguerrand.de-ribaucourt@...oirfairelinux.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux@...linux.org.uk,
        hkallweit1@...il.com
Subject: Re: [PATCH v3 0/2] net: dp83822: fix interrupt floods

On Thu, Jun 23, 2022 at 03:46:43PM +0200, Enguerrand de Ribaucourt wrote:
> The false carrier and RX error counters, once half full, produce interrupt
> floods. Since we do not use these counters, these interrupts should be disabled.
> 
> v2: added Fixes: and patchset description 0/2
> v3: Fixed Fixes: commit format
> 
> In-Reply-To: YqzAKguRaxr74oXh@...n.ch
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")

It is maybe only part of the netdev FAQ, but it states there, don't
post new versions of the patches in less than 24 hours. You need to
give people time to review the changes and make comments.

It is correct to append a Reviewed-by, but it should only be to the
patch which was actually reviewed. So please add my Reviewed-by to
just patch 1/2. The Fixes should also be on each individual patch, not
the 0/X patch, since that often gets lost in the noise.

    Andrew